WIP: Build with target wasm

IsabelParedes commented 6 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. For further details, please see https://github.com/conda-forge/conda-forge.github.io/issues/2102.

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

IsabelParedes commented 6 months ago

@conda-forge-admin, please rerender

certik commented 6 months ago

Thanks @IsabelParedes for the PR!

Let's document what the blockers are and let's fix them one by one.

Is setting WASI_SDK_PATH one such blocker? Does the suggestion from @Shaikh-Ubaid above help?

Are there other blockers?

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

You are setting MACOSX_SDK_VERSION below c_stdlib_version, in conda_build_config.yaml which is not possible! Please ensure MACOSX_SDK_VERSION is at least c_stdlib_version (you can leave it out if it is equal). If you are not setting c_stdlib_version yourself, this means you are requesting a version below the current global baseline in conda-forge. In this case, you also need to override c_stdlib_version and MACOSX_DEPLOYMENT_TARGET locally.

IsabelParedes commented 6 months ago

[  4%] Cross compiling lfortran_intrinscs.c to lfortran_runtime_wasm.o
../../../../wasi-sdk-22.0/bin/clang: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by ../../../../wasi-sdk-22.0/bin/clang)
make[2]: *** [src/runtime/legacy/CMakeFiles/lfortran_runtime_wasm.dir/build.make:73: src/runtime/legacy/lfortran_runtime_wasm.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:692: src/runtime/legacy/CMakeFiles/lfortran_runtime_wasm.dir/all] Error 2

IsabelParedes commented 6 months ago

@Shaikh-Ubaid @certik

When building locally from the main branch (commit 0ea994d2c6bf834ca73fd298bd5e4256db4769b4), it is not necessary to have the wasi-sdk installed. So I'm not sure if WASI_SKD_PATH is a problem in general or just an problem for this version.

Shaikh-Ubaid commented 6 months ago

When building locally from the main branch (commit 0ea994d2c6bf834ca73fd298bd5e4256db4769b4), it is not necessary to have the wasi-sdk installed. So I'm not sure if WASI_SKD_PATH is a problem in general or just an problem for this version.

You need atleast WASI_SDK_PATH or EMSDK_PATH to be set. (Having both of them set should be fine, I think.)

WASI_SDK_PATH is needed if you want to use clang wasi for linking and target the wasi architecture, that is lfortran examples/expr2.py --target=wasm32-wasi
EMSDK_PATH is needed if you want to use emscripten, that is lfortran examples/expr2.py --target=wasm32-unknown-emscripten

Shaikh-Ubaid commented 5 months ago

Looks like both 19 and 21 did not work. I will explore this on coming Saturday/Sunday.

Shaikh-Ubaid commented 5 months ago

We made some progress over here https://github.com/conda-forge/lfortran-feedstock/pull/83. I think we are close. Also some observations:

strangely config.h is expected to be auto-generated by cmake, but it does not seems to be getting generated or the WASI_SDK/bin/clang gets executed earlier than the generation of config.h (and thus cannot find it).
Using emsdk would not help for lfortran 0.35.0. EMSDK_PATH is supported in the latest main at LFortran, but the release 0.35.0 does not have support for it. (we might need to make/wait-for another release).

certik commented 5 months ago

We can make a new release of LFortran any time. Just let me know.

IsabelParedes commented 5 months ago

Thanks for the new release!!!

IsabelParedes commented 5 months ago

Closing this in favor of v0.36.0 https://github.com/conda-forge/lfortran-feedstock/pull/84

conda-forge / lfortran-feedstock

WIP: Build with target wasm #82