Closed bollwyvl closed 7 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Sure, if it helps. Feel free to add yourself as a maintainer as well.
So the find_library
call doesn't work? Honestly wouldn't be surprised, but figured I'd ask.
Though it might be worth considering adding this to these scripts to that Python package's conda recipe instead.
Thanks for the review!
So the find_library call doesn't work? Honestly wouldn't be surprised, but figured I'd ask.
Indeed it does not... in my hacked-up staged-recipes with libarchive-c
and diffoscope
and this recipe as in this PR, I'm getting good builds % my screw-ups...
Though it might be worth considering adding this to these scripts to that Python package's conda recipe instead.
Hm, in trolling about, I haven't found anything other than that particular downstream which is expecting that environment. @msarahan also suggested patching that check... what is the greater sin?
Anyhow... I'll PR with that change in place. Wasn't excited about hacking this one anyway!
In some more looking, I've found a number of other libraries that do wonky things around finding libarchive for some reason, so let's close this one!
This adds activate/deactivate scripts for downstreams that will be expecting
$LIBARCHIVE
to find the .so/.dylib.