search

conda-forge / libarchive-feedstock

A conda-smithy repository for libarchive.
BSD 3-Clause "New" or "Revised" License
2 stars 26 forks source link

libarchive v3.4.3 #55

Closed regro-cf-autotick-bot closed 3 years ago

regro-cf-autotick-bot commented 3 years ago

It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version. Checklist before merging this PR:
    • [ ] Dependencies have been updated if changed: see upstream
    • [ ] Tests have passed
    • [ ] Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

Closes: #54

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/51995, please use this URL for debugging

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :( Help is very welcome!

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 3 years ago

@mingwandroid I refreshed one patch and removed other two that seems to be upstream. One in a different form. Do you mind double checking if I got it right?

mingwandroid commented 3 years ago

On Linux, libiconv should never be used. On macOS it should be used for any package that supports it.

wolfv commented 3 years ago

looks great to me

mingwandroid commented 3 years ago

Looks like iconv is not needed/being used on Windows.

@conda-forge/core could we think about enabling --error-overlinking and --error-overdepending by default (with a way to override them)?

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=216053&view=logs&j=a70f640f-cc53-5cd3-6cdc-236a1aa90802&t=f5d15007-a01c-5ad8-c9ce-4d519d3b275f&l=2029

wolfv commented 3 years ago

but libiconv is only installed on osx now?

wolfv commented 3 years ago

so something else pulls in libiconv?

beckermr commented 3 years ago

@conda-forge/core could we think about enabling --error-overlinking and --error-overdepending by default (with a way to override them)?

We do this on staged-recipes, but not on feedstocks. We should discuss this at a core meeting!

mingwandroid commented 3 years ago

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=216053&view=logs&j=a70f640f-cc53-5cd3-6cdc-236a1aa90802&t=f5d15007-a01c-5ad8-c9ce-4d519d3b275f&l=1953

WARNING (libarchive,Library/bin/bsdcpio.exe): Needed DSO Library/bin/iconv.dll found in ['libiconv']
WARNING (libarchive,Library/bin/bsdcpio.exe): .. but ['libiconv'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
WARNING (libarchive,Library/bin/bsdcpio.exe): Needed DSO Library/bin/charset.dll found in ['libiconv']
WARNING (libarchive,Library/bin/bsdcpio.exe): .. but ['libiconv'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

Yeah, something else probably pulls it in and the build finds and uses it but we do not declare that fact and end up with a missing dependency. Those are baaad.

mingwandroid commented 3 years ago

2 fixes:

  1. Decide libiconv doesn't bring much to the party here (it might do! filename conversion etc) and, if there's not an easy configure switch to disable libiconv then rename libiconv.lib (and perhaps .dll) during the build (best to rename them back at the end, the host_env shouldn't be messed with too much!)
  2. Change to - libiconv # [not linux]

It might be nice to make an effort to flush libiconv out of the ecosystem on Linux too. It being built into glibc makes that a reasonable goal.

ocefpaf commented 3 years ago

I guess that 2 would not help here, right? We need to flushed it out from the dependencies that are bringing it to Windows.

mingwandroid commented 3 years ago

I believe libiconv probably serves a very useful purpose here, namely converting paths from their stored encoding to the file system's encoding and vice-versa. I think adding it as a dep on Windows is the correct fix.

mingwandroid commented 3 years ago

So, I think 2 is the correct approach, personally.

ocefpaf commented 3 years ago

So, I think 2 is the correct approach, personally.

Done! Thanks!!

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

wolfv commented 3 years ago

libiconv and libicu are pulled in from tinyxml. I wonder if we should fix tinyxml2...