[X] Bumped the build number (if the version is unchanged)
[X] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.
The need to build libarchive with /MD to use a multithreaded DLL runtime has been recognized before: the repository has 0009-CMake-Force-Multi-threaded-DLL-runtime.patch which adds /MD to the cl command line, but that patch is currently not applied. This PR addresses the problem by omitting CMAKE_C_FLAGS_RELEASE in the CMake invocation. CMake will then honor default flags for the platform (Modules\Platform\Windows-MSVC.cmake, in this case) in addition to CFLAGS from the environment.
This also means that NDEBUG will be defined for a release build, which, according to a comment in build_libarchive.dat will break the tests. However, the tests are disabled, and several of them fail, regardless of whether NDEBUG is defined or not. Defining NDEBUG seems inconsequential.
Checklist
conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)The need to build
libarchive
with/MD
to use a multithreaded DLL runtime has been recognized before: the repository has0009-CMake-Force-Multi-threaded-DLL-runtime.patch
which adds/MD
to thecl
command line, but that patch is currently not applied. This PR addresses the problem by omittingCMAKE_C_FLAGS_RELEASE
in the CMake invocation. CMake will then honor default flags for the platform (Modules\Platform\Windows-MSVC.cmake
, in this case) in addition toCFLAGS
from the environment.This also means that
NDEBUG
will be defined for a release build, which, according to a comment inbuild_libarchive.dat
will break the tests. However, the tests are disabled, and several of them fail, regardless of whetherNDEBUG
is defined or not. DefiningNDEBUG
seems inconsequential.