Link against the system's libunwind

conda-forge / libcxx-feedstock

A conda-smithy repository for libcxx.

BSD 3-Clause "New" or "Revised" License

2 stars 19 forks source link

Link against the system's libunwind #167

Closed jjerphan closed 3 months ago

jjerphan commented 3 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

See: https://libcxx.llvm.org/ReleaseNotes/18.html#build-system-changes

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

jjerphan commented 3 months ago

@conda-forge-admin, please rerender

jjerphan commented 3 months ago

Let's iterate on dev, I let you steer the resolution. :wink:

h-vetinari commented 3 months ago

OK, so the linux failure in #167 means we might have a shot at removing libunwind again completely (I wasn't optimistic at first). Looks like this causes things to fail similarly as they did for libunwind - another question of spurious C++ flags breaking the C-only detection of pthreads.

jjerphan commented 3 months ago

libcxx-feedstock repackaging libunwind seems curious to me as conda-forge/libunwind-feedstock is dedicated to its distribution (hence the deletion in 6777c33).

What was the reason for redistributing it?

h-vetinari commented 3 months ago

Please see #160 for that topic. But if the changes here work, we might not even need that.

h-vetinari commented 3 months ago

Ugh, https://github.com/conda-forge/arcticdb-feedstock/pull/251 still fails with the build from #168. It looked like a really good lead though... 😑