Add AMD support - Githubissues

conda-forge / libhwloc-feedstock

A conda-smithy repository for libhwloc.

BSD 3-Clause "New" or "Revised" License

0 stars 9 forks source link

Add AMD support #62

Closed jan-janssen closed 1 year ago

jan-janssen commented 1 year ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jan-janssen commented 1 year ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libhwloc-feedstock/actions/runs/5488247399.

jan-janssen commented 1 year ago

@isuruf Can you take a look at this pull request? I try to implement the AMD GPU support.

jan-janssen commented 1 year ago

Somehow the windows test failed, but this seems to be unrelated to the changes in this pull request:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise>CALL "VC\Auxiliary\Build\vcvars64.bat" -vcvars_ver=14.29 10.0.22621.0 
**********************************************************************
** Visual Studio 2022 Developer Command Prompt v17.6.4
** Copyright (c) 2022 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
        1 file(s) copied.
        1 file(s) copied.
        1 file(s) copied.
You need to run patch_libtool bash function after configure to fix the libtool script.
If your package uses OpenMP, add llvm-openmp to your host and run requirements.
make: *** No targets specified and no makefile found.  Stop.

jan-janssen commented 1 year ago

@isuruf Unfortunately, the windows tests still fail with the same error - can you take a look?

jan-janssen commented 1 year ago

@conda-forge-admin, please rerender

isuruf commented 1 year ago

@jan-janssen, when you cherry-pick my commits, please use my name and email as the author for the git commit in the future.

jan-janssen commented 1 year ago

@jan-janssen, when you cherry-pick my commits, please use my name and email as the author for the git commit in the future.

Sure, thanks for the heads up