Do we need to set environment variable `IGNITION_VERSION`?

conda-forge / libignition-gazebo-feedstock

A conda-smithy repository for libignition-gazebo.

BSD 3-Clause "New" or "Revised" License

4 stars 4 forks source link

Open wolfv opened 2 years ago

wolfv commented 2 years ago

In the CMakeLists of "dolly" they check for the env var of IGNITION_VERSION to be set to "fortress" in order to search for ignition-gazebo6.

I was wondering if we should also set that in an activation script? Thoughts?

Tobias-Fischer commented 2 years ago

Yes I think I've seen this elsewhere (the ROS ign packages maybe). Good idea!

traversaro commented 2 years ago

In the specific case, IGNITION_VERSION is specified by the CI, see https://github.com/chapulina/dolly/blob/6a9b6d698a38cca092901257ca4343d8b2a40176/.github/workflows/ci.yml#L33 . I would be inclined not to define such a variable, for two main reasons:

Consistency with apt/homebrew packages: I do not think any apt/homebrew package of Modern Gazebo (i.e. what was formerly known as Ignition) defines it
As "Modern Gazebo"/Ignition distributions are meant to be side-by-side installable I am not sure setting, I do not think it make sense to have a single env variable.

However, I would need to check how ros_ign build system works. Perhaps @chapulina herself may have some input on this?

wolfv commented 2 years ago

Actually, i saw that in the released version of this package Gazebo5 is hard coded... sadly