search

conda-forge / libignition-physics-feedstock

A conda-smithy repository for libignition-physics.
BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

libignition-physics v4.0.0 #14

Closed regro-cf-autotick-bot closed 3 years ago

regro-cf-autotick-bot commented 3 years ago

It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version. Checklist before merging this PR:
    • [ ] Dependencies have been updated if changed: see upstream
    • [ ] Tests have passed
    • [ ] Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/706569063, please use this URL for debugging

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :( Help is very welcome!

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 3 years ago

Needs https://github.com/conda-forge/libignition-common-feedstock/pull/29 and https://github.com/conda-forge/libsdformat-feedstock/pull/27

traversaro commented 3 years ago

Dependencies updated based on https://github.com/ignition-tooling/gazebodistro/blob/master/ign-physics4.yaml .

traversaro commented 3 years ago

@conda-forge-admin please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

traversaro commented 3 years ago

Two test failure, but that highlighted real problems:

The following tests FAILED:
     19 - INTEGRATION_ExamplesBuild_TEST (Failed)
     48 - UNIT_WorldFeatures_TEST (Failed)

Related PRs:

traversaro commented 3 years ago

One test failure is strange, as latest dartsim should be linked against bullet 3.09 .

48/75 Test #48: UNIT_WorldFeatures_TEST .....................***Failed    0.06 sec
[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from WorldFeaturesFixture
[ RUN      ] WorldFeaturesFixture.CollisionDetector
Error while loading the library [$SRC_DIR/build/lib/libignition-physics4-dartsim-plugin.so.4.0.0]: libBulletDynamics.so.2.89: cannot open shared object file: No such file or directory
[ignition::plugin::Loader::LookupPlugin] Failed to get info for [ignition::physics::dartsim::Plugin]. Could not find a plugin with that name or alias.
../dartsim/src/WorldFeatures_TEST.cc:62: Failure
Expected: (nullptr) != (this->engine), actual: (nullptr) vs 0
[  FAILED  ] WorldFeaturesFixture.CollisionDetector (1 ms)
[ RUN      ] WorldFeaturesFixture.Solver
Error while loading the library [$SRC_DIR/build/lib/libignition-physics4-dartsim-plugin.so.4.0.0]: libBulletDynamics.so.2.89: cannot open shared object file: No such file or directory
[ignition::plugin::Loader::LookupPlugin] Failed to get info for [ignition::physics::dartsim::Plugin]. Could not find a plugin with that name or alias.
../dartsim/src/WorldFeatures_TEST.cc:62: Failure
Expected: (nullptr) != (this->engine), actual: (nullptr) vs 0
[  FAILED  ] WorldFeaturesFixture.Solver (1 ms)
traversaro commented 3 years ago

One test failure is strange, as latest dartsim should be linked against bullet 3.09 .

A dartsim rebuild (https://github.com/conda-forge/dartsim-feedstock/pull/9) seem to have fixed the problem, now the problem seems to be on Windows:

2021-04-03T13:36:40.6871269Z BulletDynamics.lib(btRigidBody.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6879189Z BulletCollision.lib(btCollisionObject.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6880513Z BulletCollision.lib(btCollisionShape.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6881567Z BulletCollision.lib(btConvexShape.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6882739Z BulletCollision.lib(btDbvt.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6883781Z BulletCollision.lib(btPolyhedralConvexShape.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6885038Z BulletCollision.lib(btConvexPolyhedron.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6886027Z LinearMath.lib(btConvexHull.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6887059Z LinearMath.lib(btConvexHullComputer.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6888094Z LinearMath.lib(btGeometryUtil.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj

Bullet seems to be compiled with the wrong compilation options on Windows (MT instead of MD).

traversaro commented 3 years ago

2021-04-03T13:36:40.6871269Z BulletDynamics.lib(btRigidBody.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj 2021-04-03T13:36:40.6879189Z BulletCollision.lib(btCollisionObject.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj 2021-04-03T13:36:40.6880513Z BulletCollision.lib(btCollisionShape.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj 2021-04-03T13:36:40.6881567Z BulletCollision.lib(btConvexShape.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj 2021-04-03T13:36:40.6882739Z BulletCollision.lib(btDbvt.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj 2021-04-03T13:36:40.6883781Z BulletCollision.lib(btPolyhedralConvexShape.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj 2021-04-03T13:36:40.6885038Z BulletCollision.lib(btConvexPolyhedron.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj 2021-04-03T13:36:40.6886027Z LinearMath.lib(btConvexHull.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj 2021-04-03T13:36:40.6887059Z LinearMath.lib(btConvexHullComputer.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj 2021-04-03T13:36:40.6888094Z LinearMath.lib(btGeometryUtil.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj

Fix: https://github.com/conda-forge/bullet-feedstock/pull/33 .

Tobias-Fischer commented 3 years ago

Hi @traversaro - do you have any ideas what the errors on OSX/Win are about?

traversaro commented 3 years ago

Hi @traversaro - do you have any ideas what the errors on OSX/Win are about?

Windows failure seems related to the FAKE_INSTALL_PREFIX test in which the library is installed in a prefix, probably https://github.com/ignitionrobotics/ign-physics/blob/b5e05110cdc09aa2a9def4fc7ca4ba971550a103/test/integration/CMakeLists.txt#L44 is a Unixism, skipping is probably safe. Not sure instead on the macOS failure, I have added it to the list of things to check with a session on a real macOS machine (that got a bit delayed on my side, sorry, but I should be doing soon).

traversaro commented 3 years ago

I removed myself as an assignee, I still intend to tackle this in the future, but I do not want to give the false impression that it is going to be in the next few hours at this point. : )

diegoferigo commented 3 years ago

@traversaro @Tobias-Fischer since the Linux build seems succeeding, do you think it would be possible / useful proceeding only with it and deferring macOS and Windows to a later time? The same would apply for https://github.com/conda-forge/libignition-gazebo-feedstock/pull/5.

traversaro commented 3 years ago

The same would apply for conda-forge/libignition-gazebo-feedstock#5.

ignition-gazebo is already Linux-only at the moment.

traversaro commented 3 years ago

@traversaro @Tobias-Fischer since the Linux build seems succeeding, do you think it would be possible / useful proceeding only with it and deferring macOS and Windows to a later time?

Done in https://github.com/conda-forge/libignition-physics-feedstock/pull/14/commits/8bed48edcf0c74396391eb3f5dc5a0b26f55888f, issue to fix mac/Linux support added in https://github.com/conda-forge/libignition-physics-feedstock/issues/15 .

traversaro commented 3 years ago

@conda-forge-admin please rerender

Tobias-Fischer commented 3 years ago

Seems like the Linux build now errors at the FAKE_INSTALL step as well (as the Windows build previously did). Shall we disable the INTEGRATION_ExamplesBuild_TEST which seems to be the only test that depends on the FAKE_INSTALL? In this case, we could also try enabling Windows again.

traversaro commented 3 years ago

Seems like the Linux build now errors at the FAKE_INSTALL step as well (as the Windows build previously did). Shall we disable the INTEGRATION_ExamplesBuild_TEST which seems to be the only test that depends on the FAKE_INSTALL? In this case, we could also try enabling Windows again.

Yes, I think it is a good idea!

diegoferigo commented 3 years ago

Pardon for the second ping, can I do anything to speed up this PR? If I understood correctly, it is currently blocked by a test that could be disabled in CI.

traversaro commented 3 years ago

@diegoferigo even if you are not a mantainer of the repo, you can fork directly from the branch https://github.com/regro-cf-autotick-bot/libignition-physics-feedstock/tree/4.0.0_hd81ae1 and open a new PR with the changes from a fork of yours in which you can do that changes that you prefer.

Tobias-Fischer commented 3 years ago

@conda-forge-admin please rerender

Tobias-Fischer commented 3 years ago

@conda-forge-admin please rerender

Tobias-Fischer commented 3 years ago

@conda-forge-admin please rerender

Tobias-Fischer commented 3 years ago

@conda-forge-admin please rerender

Tobias-Fischer commented 3 years ago

@conda-forge-admin please rerender

Tobias-Fischer commented 3 years ago

Needs https://github.com/conda-forge/vc-feedstock/issues/36

Tobias-Fischer commented 3 years ago

Error for reference:

23/43 Test #23: UNIT_Collisions_TEST .................***Failed    0.12 sec
[==========] Running 3 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 3 tests from PhysicsPlugins/Collisions_TEST
[ RUN      ] PhysicsPlugins/Collisions_TEST.MeshAndPlane/0
[Err] [..\src\SystemPaths.cc:372] Unable to find file with URI [D:///bld/libignition-physics4_1624498949592/work/resources/chassis.dae]
[Err] [..\src\SystemPaths.cc:462] Could not resolve file [D:/bld/libignition-physics4_1624498949592/work/resources/chassis.dae]
[Err] [..\graphics\src\MeshManager.cc:172] Unable to find file[D:/bld/libignition-physics4_1624498949592/work/resources/chassis.dae]
Testing library D:/bld/libignition-physics4_1624498949592/work/build/bin/ignition-physics4-dartsim-plugin.dll
 -- Plugin name: ignition::physics::dartsim::Plugin
unknown file: error: SEH exception with code 0xc0000005 thrown in the test body.
[  FAILED  ] PhysicsPlugins/Collisions_TEST.MeshAndPlane/0, where GetParam() = "D:/bld/libignition-physics4_1624498949592/work/build/bin/ignition-physics4-dartsim-plugin.dll" (27 ms)
[ RUN      ] PhysicsPlugins/Collisions_TEST.MeshAndPlane/1
[       OK ] PhysicsPlugins/Collisions_TEST.MeshAndPlane/1 (0 ms)
[ RUN      ] PhysicsPlugins/Collisions_TEST.MeshAndPlane/2
[       OK ] PhysicsPlugins/Collisions_TEST.MeshAndPlane/2 (0 ms)
[----------] 3 tests from PhysicsPlugins/Collisions_TEST (27 ms total)

[----------] Global test environment tear-down
[==========] 3 tests from 1 test case ran. (27 ms total)
[  PASSED  ] 2 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] PhysicsPlugins/Collisions_TEST.MeshAndPlane/0, where GetParam() = "D:/bld/libignition-physics4_1624498949592/work/build/bin/ignition-physics4-dartsim-plugin.dll"

 1 FAILED TEST
Tobias-Fischer commented 3 years ago

@traversaro - what do you think is the best way forward here?

traversaro commented 3 years ago

If only a test is failing, probably just skipping the offending test in ctest may be the best compromise.