conda-forge / libignition-physics-feedstock

A conda-smithy repository for libignition-physics.
BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

Add libccd-double and assimp explicit dependency #29

Closed traversaro closed 1 year ago

traversaro commented 1 year ago

I noticed that the ignition-physics-dartsim-plugin file actually links ccd and assimp due to https://github.com/dartsim/dart/blob/189e24d5624f3007fe13d2c27bbdb9a83ed135ec/dart/CMakeLists.txt#L132 . I am not sure how we should handle this, but the easiest solution is to just depend on assimp and ccd explicitly also here.

Checklist

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 1 year ago

Without this fix, ign gazebo -s was failing with error:

Error while loading the library [C:\Users\STraversaro\AppData\Local\mambaforge\envs\libignition-gazebo6\Library\lib\ign-physics-5\engine-plugins\ignition-physics-dartsim-plugin.dll]: "C:\Users\STraversaro\AppData\Local\mambaforge\envs\libignition-gazebo6\Library\lib\ign-physics-5\engine-plugins\ignition-physics-dartsim-plugin.dll": The specified module could not be found.
[Err] [D:\bld\libignition-gazebo6_1666276524907\work\src\systems\physics\Physics.cc:771] Unable to load the [C:\Users\STraversaro\AppData\Local\mambaforge\envs\libignition-gazebo6\Library\lib\ign-physics-5\engine-plugins\ignition-physics-dartsim-plugin.dll] library.

Because ignition-physics-dartsim-plugin.dll was not finding the correct assimp library (it was searching for assimp-vc141 that is the name of 5.2.4 (see https://github.com/conda-forge/assimp-feedstock/pull/47), while assimp 5.2.5 was actually installed.

traversaro commented 1 year ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!