Add PR 437 to fix https://github.com/RoboStack/ros-humble/issues/33

conda-forge / libignition-physics-feedstock

A conda-smithy repository for libignition-physics.

BSD 3-Clause "New" or "Revised" License

1 stars 3 forks source link

Add PR 437 to fix https://github.com/RoboStack/ros-humble/issues/33 #31

Closed Tobias-Fischer closed 1 year ago

Tobias-Fischer commented 1 year ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

See https://github.com/RoboStack/ros-humble/issues/33:

RuntimeError: copy_symlink: The file or directory is not a reparse point.: 
"C:\Users\runneradmin\conda_pkgs_dir\libignition-physics5-5.2.0-hef61a30_2\Library\lib\ign-physics-5\engine-plugins\ignition-physics-bullet-plugin.dll", 
"C:\bld\ros-humble-ros-gz-sim-0_1671085464153\_h_env\Library\lib\ign-physics-5\engine-plugins\ignition-physics-bullet-plugin.dll"

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 1 year ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 1 year ago

/cc @traversaro

traversaro commented 1 year ago

I am currently far from keyboard, but if I recall correctly in the case of Windows if a symlink is problematic the dll is simply copied. Not installing the unversioned version will fail at runtime I am afraid. To double check we can see how all other plugins are dealt with.

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!

Tobias-Fischer commented 1 year ago

The unversioned version is still being installed via a copy. I think having both copy + symlink led to issues. According to the logs, both dlls (unversioned and versioned) are found properly now by conda-build, whereas the previous build had a 0-byte unversioned dll that caused issues.

traversaro commented 1 year ago

The unversioned version is still being installed via a copy. I think having both copy + symlink led to issues. According to the logs, both dlls (unversioned and versioned) are found properly now by conda-build, whereas the previous build had a 0-byte unversioned dll that caused issues.

Ok, great!