Closed Tobias-Fischer closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
@conda-forge-admin, please rerender
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.
@conda-forge-admin, please rerender
@conda-forge-admin , please restart build
@conda-forge-admin, please rerender
@conda-forge-admin, please rerender
@seanyen this is ready to be merged
/cc @wolfv @traversaro
You may want to add dartsim at least on unix as a dependency, otherwise the only enabled physics engine would be TPE, that is just a simple kinematic engine.
But we can also add dartsim in a following PR.
We might as well try :). Also (attempted to) fixed the other build warnings.
The failure on Windows may be due to the advanced template machinery that may require VS2019. As a workaround, we may considering using clang-cl. pinocchio-feedstock is an example of feedstock that uses this strategy.
Whoops, only saw your comment after my latest commit. Let's see whether it compiles without sdformat. I guess switching to clang-cl should be done in a new PR, otherwise it gets a little cluttered here ..
Alright, I'd say let's merge this and open an issue to add dartsim+sdformat to the win build?
See #7 and #8 for the issues to add dartsim/sdformat on Win
Alright, I'd say let's merge this and open an issue to add dartsim+sdformat to the win build?
Good idea!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)