Enable unix builds - Githubissues

conda-forge / libignition-physics-feedstock

A conda-smithy repository for libignition-physics.

BSD 3-Clause "New" or "Revised" License

1 stars 3 forks source link

Enable unix builds #6

Closed Tobias-Fischer closed 3 years ago

Tobias-Fischer commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 3 years ago

Needs https://github.com/conda-forge/libignition-plugin-feedstock/pull/3

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 3 years ago

@conda-forge-admin , please restart build

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 3 years ago

@seanyen this is ready to be merged

/cc @wolfv @traversaro

traversaro commented 3 years ago

You may want to add dartsim at least on unix as a dependency, otherwise the only enabled physics engine would be TPE, that is just a simple kinematic engine.

traversaro commented 3 years ago

But we can also add dartsim in a following PR.

Tobias-Fischer commented 3 years ago

We might as well try :). Also (attempted to) fixed the other build warnings.

traversaro commented 3 years ago

The failure on Windows may be due to the advanced template machinery that may require VS2019. As a workaround, we may considering using clang-cl. pinocchio-feedstock is an example of feedstock that uses this strategy.

Tobias-Fischer commented 3 years ago

Whoops, only saw your comment after my latest commit. Let's see whether it compiles without sdformat. I guess switching to clang-cl should be done in a new PR, otherwise it gets a little cluttered here ..

Tobias-Fischer commented 3 years ago

Alright, I'd say let's merge this and open an issue to add dartsim+sdformat to the win build?

Tobias-Fischer commented 3 years ago

See #7 and #8 for the issues to add dartsim/sdformat on Win

traversaro commented 3 years ago

Alright, I'd say let's merge this and open an issue to add dartsim+sdformat to the win build?

Good idea!