conda-forge / libignition-rendering4-feedstock

A conda-smithy repository for libignition-rendering4.
BSD 3-Clause "New" or "Revised" License
2 stars 5 forks source link

Fix meta.yaml logic for autotick-bot compatibility #15

Closed traversaro closed 3 years ago

traversaro commented 3 years ago

This PR changes the definition of the version variable to match the format used in the tags, i.e. 4_4.1.0, so that the autotick-bot (that extracts the version information from git tags by stripping all the characters till the first digit) works fine. The version in 4.1.0 format is now contained in the version_package variable (see https://github.com/conda-forge/libignition-msgs1-feedstock/issues/50 and https://github.com/conda-forge/libignition-msgs1-feedstock/issues/53 ).

Checklist

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

traversaro commented 3 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.