conda-forge / libignition-rendering4-feedstock

A conda-smithy repository for libignition-rendering4.
BSD 3-Clause "New" or "Revised" License
2 stars 5 forks source link

Add activation scripts to workaround problem in relocatability #27

Closed traversaro closed 2 years ago

traversaro commented 2 years ago

Fix https://github.com/conda-forge/libignition-rendering4-feedstock/issues/25 .

The activation scripts are far from perfect, I have opened https://github.com/conda-forge/libignition-rendering4-feedstock/issues/26 to track that.

Checklist

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

traversaro commented 2 years ago

Testing a local version of this package on ign-sensors's examples/save_image, the image is correctly generated on Windows: image

Tobias-Fischer commented 2 years ago

Thanks for this @traversaro! Should we use $PKG_NAME instead of hard coding the name though so it's less work when updating versions?

traversaro commented 2 years ago

Thanks for this @traversaro! Should we use $PKG_NAME instead of hard coding the name though so it's less work when updating versions?

Sure! That was what I wanted to track in https://github.com/conda-forge/libignition-rendering4-feedstock/issues/26 , for the first version I wanted to minize the possibility of doing something wrong. : )