Enable ogre-next dependency

traversaro commented 2 years ago

Once packages merged in https://github.com/conda-forge/staged-recipes/pull/19384 are available, we can start the CI.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libignition-rendering4-feedstock/actions/runs/2561501673.

traversaro commented 2 years ago

Blocked also by https://github.com/conda-forge/ogre-next-feedstock/pull/1 .

traversaro commented 2 years ago

Build is failing with:

2022-06-26T14:28:05.2310076Z /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/work/ogre2/src/terrain/Terra/src/Hlms/OgreHlmsTerra.cpp: In member function 'Ogre::uint32 Ogre::HlmsTerra::fillBuffersFor(const Ogre::HlmsCache*, const Ogre::QueuedRenderable&, bool, Ogre::uint32, Ogre::CommandBuffer*, bool)':
2022-06-26T14:28:05.2320272Z /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/work/ogre2/src/terrain/Terra/src/Hlms/OgreHlmsTerra.cpp:594:78: error: no matching function for call to 'Ogre::HlmsListener::hlmsTypeChanged(bool&, Ogre::CommandBuffer*&, const Ogre::HlmsTerraDatablock*&)'
2022-06-26T14:28:05.2322213Z   594 |             mListener->hlmsTypeChanged( casterPass, commandBuffer, datablock );
2022-06-26T14:28:05.2323045Z       |                                                                              ^
2022-06-26T14:28:05.2324420Z In file included from /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/work/ogre2/src/terrain/Terra/src/Hlms/OgreHlmsTerra.cpp:32:
2022-06-26T14:28:05.2327002Z /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/OGRE-Next/OgreHlmsListener.h:167:22: note: candidate: 'virtual void Ogre::HlmsListener::hlmsTypeChanged(bool, Ogre::CommandBuffer*, const Ogre::HlmsDatablock*, size_t)'
2022-06-26T14:28:05.2328619Z   167 |         virtual void hlmsTypeChanged( bool casterPass, CommandBuffer *commandBuffer,
2022-06-26T14:28:05.2329502Z       |                      ^~~~~~~~~~~~~~~
2022-06-26T14:28:05.2331189Z /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/OGRE-Next/OgreHlmsListener.h:167:22: note:   candidate expects 4 arguments, 3 provided
2022-06-26T14:28:05.9637710Z make[2]: *** [ogre2/src/terrain/Terra/CMakeFiles/terra.dir/build.make:90: ogre2/src/terrain/Terra/CMakeFiles/terra.dir/src/Hlms/OgreHlmsTerra.cpp.o] Error 1
2022-06-26T14:28:05.9645118Z make[1]: *** [CMakeFiles/Makefile2:3029: ogre2/src/terrain/Terra/CMakeFiles/terra.dir/all] Error 2
2022-06-26T14:28:05.9646112Z make: *** [Makefile:146: all] Error 2

Probably ign-rendering needs to be updated for Ogre-Next 2.3.0 compatibility, until now it has only had only compatibility with Ogre-Next 2.2.*, see Ogre-Next changelog (https://ogrecave.github.io/ogre-next/api/2.3/_ogre23_changes.html):

HlmsListener::hlmsTypeChanged added an argument. Beware of it if you are overloading this function

traversaro commented 2 years ago

Build is failing with:

2022-06-26T14:28:05.2310076Z /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/work/ogre2/src/terrain/Terra/src/Hlms/OgreHlmsTerra.cpp: In member function 'Ogre::uint32 Ogre::HlmsTerra::fillBuffersFor(const Ogre::HlmsCache*, const Ogre::QueuedRenderable&, bool, Ogre::uint32, Ogre::CommandBuffer*, bool)':
2022-06-26T14:28:05.2320272Z /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/work/ogre2/src/terrain/Terra/src/Hlms/OgreHlmsTerra.cpp:594:78: error: no matching function for call to 'Ogre::HlmsListener::hlmsTypeChanged(bool&, Ogre::CommandBuffer*&, const Ogre::HlmsTerraDatablock*&)'
2022-06-26T14:28:05.2322213Z   594 |             mListener->hlmsTypeChanged( casterPass, commandBuffer, datablock );
2022-06-26T14:28:05.2323045Z       |                                                                              ^
2022-06-26T14:28:05.2324420Z In file included from /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/work/ogre2/src/terrain/Terra/src/Hlms/OgreHlmsTerra.cpp:32:
2022-06-26T14:28:05.2327002Z /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/OGRE-Next/OgreHlmsListener.h:167:22: note: candidate: 'virtual void Ogre::HlmsListener::hlmsTypeChanged(bool, Ogre::CommandBuffer*, const Ogre::HlmsDatablock*, size_t)'
2022-06-26T14:28:05.2328619Z   167 |         virtual void hlmsTypeChanged( bool casterPass, CommandBuffer *commandBuffer,
2022-06-26T14:28:05.2329502Z       |                      ^~~~~~~~~~~~~~~
2022-06-26T14:28:05.2331189Z /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/OGRE-Next/OgreHlmsListener.h:167:22: note:   candidate expects 4 arguments, 3 provided
2022-06-26T14:28:05.9637710Z make[2]: *** [ogre2/src/terrain/Terra/CMakeFiles/terra.dir/build.make:90: ogre2/src/terrain/Terra/CMakeFiles/terra.dir/src/Hlms/OgreHlmsTerra.cpp.o] Error 1
2022-06-26T14:28:05.9645118Z make[1]: *** [CMakeFiles/Makefile2:3029: ogre2/src/terrain/Terra/CMakeFiles/terra.dir/all] Error 2
2022-06-26T14:28:05.9646112Z make: *** [Makefile:146: all] Error 2

Probably ign-rendering needs to be updated for Ogre-Next 2.3.0 compatibility, until now it has only had only compatibility with Ogre-Next 2.2.*, see Ogre-Next changelog (https://ogrecave.github.io/ogre-next/api/2.3/_ogre23_changes.html):

HlmsListener::hlmsTypeChanged added an argument. Beware of it if you are overloading this function

ignition-rendering is migrated to ogre-next 2.3.0 in https://github.com/gazebosim/gz-rendering/pull/553, but that is just for the branch that will become gz-rendering7. I am not sure how easy it will be to backport the change. Probably it may be easier to just produce ogre-next 2.2 binaries and use those here.

traversaro commented 2 years ago

Build is failing with:

2022-06-26T14:28:05.2310076Z /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/work/ogre2/src/terrain/Terra/src/Hlms/OgreHlmsTerra.cpp: In member function 'Ogre::uint32 Ogre::HlmsTerra::fillBuffersFor(const Ogre::HlmsCache*, const Ogre::QueuedRenderable&, bool, Ogre::uint32, Ogre::CommandBuffer*, bool)':
2022-06-26T14:28:05.2320272Z /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/work/ogre2/src/terrain/Terra/src/Hlms/OgreHlmsTerra.cpp:594:78: error: no matching function for call to 'Ogre::HlmsListener::hlmsTypeChanged(bool&, Ogre::CommandBuffer*&, const Ogre::HlmsTerraDatablock*&)'
2022-06-26T14:28:05.2322213Z   594 |             mListener->hlmsTypeChanged( casterPass, commandBuffer, datablock );
2022-06-26T14:28:05.2323045Z       |                                                                              ^
2022-06-26T14:28:05.2324420Z In file included from /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/work/ogre2/src/terrain/Terra/src/Hlms/OgreHlmsTerra.cpp:32:
2022-06-26T14:28:05.2327002Z /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/OGRE-Next/OgreHlmsListener.h:167:22: note: candidate: 'virtual void Ogre::HlmsListener::hlmsTypeChanged(bool, Ogre::CommandBuffer*, const Ogre::HlmsDatablock*, size_t)'
2022-06-26T14:28:05.2328619Z   167 |         virtual void hlmsTypeChanged( bool casterPass, CommandBuffer *commandBuffer,
2022-06-26T14:28:05.2329502Z       |                      ^~~~~~~~~~~~~~~
2022-06-26T14:28:05.2331189Z /home/conda/feedstock_root/build_artifacts/libignition-rendering6_1656252452994/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/OGRE-Next/OgreHlmsListener.h:167:22: note:   candidate expects 4 arguments, 3 provided
2022-06-26T14:28:05.9637710Z make[2]: *** [ogre2/src/terrain/Terra/CMakeFiles/terra.dir/build.make:90: ogre2/src/terrain/Terra/CMakeFiles/terra.dir/src/Hlms/OgreHlmsTerra.cpp.o] Error 1
2022-06-26T14:28:05.9645118Z make[1]: *** [CMakeFiles/Makefile2:3029: ogre2/src/terrain/Terra/CMakeFiles/terra.dir/all] Error 2
2022-06-26T14:28:05.9646112Z make: *** [Makefile:146: all] Error 2

Probably ign-rendering needs to be updated for Ogre-Next 2.3.0 compatibility, until now it has only had only compatibility with Ogre-Next 2.2.*, see Ogre-Next changelog (https://ogrecave.github.io/ogre-next/api/2.3/_ogre23_changes.html):

HlmsListener::hlmsTypeChanged added an argument. Beware of it if you are overloading this function

ignition-rendering is migrated to ogre-next 2.3.0 in gazebosim/gz-rendering#553, but that is just for the branch that will become gz-rendering7. I am not sure how easy it will be to backport the change. Probably it may be easier to just produce ogre-next 2.2 binaries and use those here.

Done in https://github.com/conda-forge/ogre-next-feedstock/pull/3, adding the pin now.

conda-forge / libignition-rendering4-feedstock

Enable ogre-next dependency #45