conda-forge / libjxl-split-feedstock

A conda-smithy repository for libjxl-split.
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

Shared windows #23

Closed hmaarrfk closed 1 month ago

hmaarrfk commented 8 months ago

Checklist

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 8 months ago

@shockwave, @h-vetinari it seems to me that there might be some bugs in their CMake file that make certain symbols exposed via multiple libraries:

One example is: https://github.com/libjxl/libjxl/blob/f6d04b7655c6639d27cdf4c865c3a7fecf9cf268/lib/jxl_extras.cmake#L160

I'm somewhat worried about attempting to make a big cleanup, i've already failed once, my attempt here is to get the

sshockwave commented 7 months ago

I can live with building the shared libraries and the tools separately as long as we can revert it easily. I would like to keep the flexibility of testing whether future releases of libjxl have fixed this build issue.

That being said, I failed to dynamically build even only the core lib. I guess we have to link the internal libs statically and build the exposed libs dynamically. This would indeed require some changes to the CMake scripts.

libjxl_cms.lib             ---(static)---> libjxl.dll
libjxl.lib, libjxl_cms.lib ---(static)---> cjxl, djxl, and other tools
sshockwave commented 1 month ago

Fixed in #26