Fix run_exports - Githubissues

conda-forge / libode-feedstock

A conda-smithy repository for libode.

BSD 3-Clause "New" or "Revised" License

2 stars 6 forks source link

Closed Tobias-Fischer closed 3 years ago

Tobias-Fischer commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Fix #12

Checked locally and it now works as expected.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 3 years ago

Tobias-Fischer commented 3 years ago

~~Latest commit also fixes #9.~~ - couldn't get that to work and undid changes re this

Tobias-Fischer commented 3 years ago

This is ready for review @traversaro @repagh

Seems like #9 is trickier to fix than what I thought; so limiting to fix #12 for now

Tobias-Fischer commented 3 years ago

Ping @traversaro

traversaro commented 3 years ago

Thanks, this was something I was not able to crack in the past. @conda-forge/libode any further comment?

Tobias-Fischer commented 3 years ago

Thanks for checking the PR, @traversaro. @repagh - any chance of merging this?

traversaro commented 3 years ago

Thanks for checking the PR, @traversaro. @repagh - any chance of merging this?

I wanted to wait for @repagh input if any arrives, and then I can merge myself.