Update qdldl version to match the one used in upstream submodule

conda-forge / libosqp-feedstock

A conda-smithy repository for libosqp.

BSD 3-Clause "New" or "Revised" License

0 stars 5 forks source link

Update qdldl version to match the one used in upstream submodule #2

Closed traversaro closed 3 years ago

traversaro commented 3 years ago

Even if I created this feedstock ~30 hours ago, I already forgot to make sure that the qdldl version used in meta.yaml needs to be manually aligned with the one specified in the osqp version submodule.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 3 years ago

Wouldn't that be an argument to have a separate libqdldl recipe?

traversaro commented 3 years ago

Wouldn't that be an argument to have a separate libqdldl recipe?

Yes, this is indeed my plan, to remove all the vendored dependencies . From the discussion in https://github.com/oxfordcontrol/osqp/issues/85 I always tought that the vendored dependencies would have been necessary in any case to support the codegeneration functionalities, but looking more in depth the code generation is something available just at the Python/MATLAB level, so perhaps there will be no need in the end for having a vendored qdldl in this repo.