conda-forge / libosqp-feedstock

A conda-smithy repository for libosqp.
BSD 3-Clause "New" or "Revised" License
0 stars 6 forks source link

Build only shared library for CFEP-18 compliance #6

Closed traversaro closed 3 years ago

traversaro commented 3 years ago

Furthermore, as explained in https://github.com/conda-forge/libosqp-feedstock/issues/4#issuecomment-853151791 this change actually ensure that downstream consumers of the library on Windows use the shared library instead of linking the static one.

Fix https://github.com/conda-forge/libosqp-feedstock/issues/4 . The patch to realize this was proposed upstream in https://github.com/oxfordcontrol/osqp/pull/310 .

Note that in this case we don't have the problem described in https://github.com/osqp/osqp/issues/309#issuecomment-853157002 as we are using NMake Makefiles as CMake generator.

Checklist

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 3 years ago

@conda-forge-admin, please rerender

traversaro commented 3 years ago

fyi @Levi-Armstrong @johnwason