Closed brl0 closed 4 years ago
@brl0 , yes I'm aware of this unfortunate problem. The reason is that some data files moved from S3 to git and are now packaged incorrectly. I have the code locally to fix it, but don't want to build it from a random git commit (although we could do that). I asked at libpostal for a new stable version, which is just making a tag https://github.com/openvenues/libpostal/issues/477 . If this is done, I can immediately release a fix for libpostal in conda. Unfortunately, no reply :( Perhaps you can comment on it to bump the issue?
@MichaelMarien , as requested: (https://github.com/openvenues/libpostal/issues/477). I actually had already '+1' when I saw that issue. Unfortunately, based on the other issues, it does not look like they are responsive.
I am trying to get libpostal installed into a Jupyter environment through CI, so anything you could do to point me in the right direction would be greatly appreciated.
FWIW, given the current lack of responsiveness, I think releasing based on a specific commit may be warranted.
Thanks again for your contribution of time and effort on this!
@brl0 tbh, not such an expert in the guidelines at conda-forge regarding this. Do you know? Otherwise I can ask it in the gitter, if it's ok, I'd be happy to fix it.
I can also provide you the updated recipe? Not sure if that helps?
@MichaelMarien , We have some conda core maintainers, so I asked internally and this is the response I got:
how different is the commit from the release? It's not uncommon for recipes to have patches to make them work. Building from a commit that is close to the release would be not different from that
And another:
yeah 1.1alpha is the latest tagged release and it is 2 years old. latest commit is 23 days ago but maintainers look pretty unresponsive. I would say do what Aaron suggests and just tag the conda version release based on git describe --tags which is v1.1-alpha-31-g790e24bc
I think it is safe to release what you are able to get working. Let me know if there is anything I can do to assist.
@MichaelMarien ,
Thanks for your help and timeliness. You have saved my day.
For reference: the linux build should be fixed now, I'm struggling with the OS one, azure seems to time-out. Might be because of huge size now. Will investigate later.
@MichaelMarien, Thanks for packaging this great tool. Let me know how I can help.
Issue: Installed libpostal and postal. Attempted the following:
from postal.expand import expand_address
Received this error:
I am posting this issue to this feedstock because it seems that the problem may be due to the expected location of the libpostal data files.
Environment (
conda list
):Details about
conda
and system (conda info
):