[4.24.3] Added -framework CoreFoundation to LDFLAGS on OSX

conda-forge / libprotobuf-feedstock

A conda-smithy repository for libprotobuf.

BSD 3-Clause "New" or "Revised" License

3 stars 31 forks source link

[4.24.3] Added -framework CoreFoundation to LDFLAGS on OSX #191

Closed JohanMabille closed 12 months ago

JohanMabille commented 12 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

This should fix https://github.com/conda-forge/arcticdb-feedstock/pull/89 , currently failing with the following:

ImportError: dlopen(/Users/runner/miniforge3/conda-bld/arcticdb_1697103681425/_h_env_placehold_[...]/lib/python3.8/site-packages/grpc_tools/_protoc_compiler.cpython-38-darwin.so, 2): Symbol not found: _CFRelease

cc @jjerphan

conda-forge-webservices[bot] commented 12 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 12 months ago

This is not tackling the version that appears in the arcticdb PR (4.24.3 vs. 4.24.4). I'm kinda reluctant to make branches per patch version, but it seems we might have to....

JohanMabille commented 12 months ago

Oh I missed the global pinning of libprotobuf :s Anyway we will need it for the main branch anyway, so I let this PR open, but we should wait for the confirmation that this patch in 4.23 branch fixes the issue before merging it.

jjerphan commented 12 months ago

@h-vetinari: I have opened #192 to help you with maintaining the feedstock and with backporting changes.

h-vetinari commented 12 months ago

Oh I missed the global pinning of libprotobuf

The global pinning is still at 4.23.4, the newest migrator bumps that to 4.24.3. however, this feedstock is already at 4.24.4 in preparation for the next migration (unfortunately we need to migrate per patch version), which hasn't started yet.

We can create a 4.24.3 branch here to fix this, or wait for the next migration (and maybe do that sooner rather than later).

jjerphan commented 12 months ago

We can create a 4.24.3 branch here to fix this, or wait for the next migration

Let's do that.

h-vetinari commented 12 months ago

I have opened #192 to help you with maintaining the feedstock and with backporting changes.

Thanks, happy to have your help! Protobuf has a couple of idiosyncrasies compared to other feedstocks, so in cases of doubt it's better to double check. ;)

jjerphan commented 12 months ago

Should we merge #193, then? :)