search

conda-forge / libprotobuf-feedstock

A conda-smithy repository for libprotobuf.
BSD 3-Clause "New" or "Revised" License
3 stars 31 forks source link

Backporting fix for protobuf and gazebo (at least) #206

Closed hmaarrfk closed 8 months ago

hmaarrfk commented 8 months ago

Comment:

Could we backport: https://github.com/protocolbuffers/protobuf/commit/bb4718cd8720c6acb17b58b19f8345c94aaaba78

it seems to be affecting tensorflow https://github.com/conda-forge/tensorflow-feedstock/pull/371 and gazebo: https://github.com/conda-forge/gazebo-feedstock/pull/201

cc: @traversaro @Tobias-Fischer

h-vetinari commented 8 months ago

Hm, seems this patch hasn't been backported to the 25.x line (though 26.x already has a RC out).

If it's urgent, we'll have to create a branch for 4.25.1. Otherwise, I was planning to migrate grpc 1.61 & abseil 20240108 & protobuf 4.25.2 soon (which means we could add the patch on top of main here)

hmaarrfk commented 8 months ago

tensorflow cant be built without it.

happy to skip one combo of libabseil

traversaro commented 8 months ago

tensorflow cant be built without it.

happy to skip one combo of libabseil

Same for gazebo, thanks!

hmaarrfk commented 8 months ago

The best of both worlds would to back port before you merge 4.25.2.

Happy to make the PR

h-vetinari commented 8 months ago

Nevermind, I misremembered that I hadn't merged https://github.com/conda-forge/libprotobuf-feedstock/pull/202 yet. So let's go with #207 and then I'll rebase #202