Rebuild libprotobuf with a new zlib 1.3

conda-forge / libprotobuf-feedstock

A conda-smithy repository for libprotobuf.

BSD 3-Clause "New" or "Revised" License

3 stars 31 forks source link

Rebuild libprotobuf with a new zlib 1.3 #216

Closed ekomarova closed 4 months ago

ekomarova commented 6 months ago

This PR was created simply to rebuild libprotobuf with a new zlib 1.3, in order to get rid of such a restriction

libprotobuf 5.26.1 h08a7969_0
-----------------------------
file name   : libprotobuf-5.26.1-h08a7969_0.conda
dependencies:
  - libzlib >=1.2.13,<1.3.0a0

what does not allow to install libprotobuf with zlib 1.3

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ekomarova commented 6 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libprotobuf-feedstock/actions/runs/8558201563.

ekomarova commented 6 months ago

This is the wrong place to tackle this. We need to figure out whether the ABI in zlib changed from 1.2 to 1.3, and then either migrate or patch the repodata. See conda-forge/conda-forge-pinning-feedstock#5443

@h-vetinari What do you think about doing what for example libxml2 does https://github.com/conda-forge/libxml2-feedstock/pull/115? And build it for 2 versions

h-vetinari commented 6 months ago

What do you think about doing what for example libxml2 does [...] and build it for 2 versions

It's not sustainable. You would need to rebuild every protobuf-dependent package twice, and soon all of conda-forge. If zlib 1.3 is important to you, please direct your energy to https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5443.

h-vetinari commented 4 months ago

This PR is obsolete, libprotobuf can be used with zlib 1.3 now.