conda-forge / libsndfile-feedstock

A conda-smithy repository for libsndfile.
BSD 3-Clause "New" or "Revised" License
2 stars 13 forks source link

libsndfile v1.1.0 #24

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2048181198, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bmcfee commented 2 years ago

Just poking in here because this release and package build is very relevant to my interests (i.e., will affect downstream packages like librosa), and I'm not sure how closely the tagged reviewers have been following libsndfile development. Specifically, the 1.1.0 release added mp3 support, but this is not enabled in the current feedstock (see log):

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=481764&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d&l=372

Encoding and decoding mp3 requires new dependencies for lame and mpg123, both of which are packaged in conda-forge, so it should be possible to include them without too much additional effort.

wolfv commented 2 years ago

@bmcfee thanks for chiming in. That sounds wonderful. Do you want to add the two dependencies to the build and enable MP3?

You could do that in a seperate PR -- then I will hold off merging this one. You can also add yourself as a maintainer to help out with future releases, that would be wonderful.

bmcfee commented 2 years ago

Do you want to add the two dependencies to the build and enable MP3?

You could do that in a seperate PR -- then I will hold off merging this one.

I can take a crack at it, sure. Would it make sense to fork off of this PR?

You can also add yourself as a maintainer to help out with future releases, that would be wonderful.

I'd rather not get too involved - I'm not actually a libsndfile dev, just a nosy busybody with some vested interest in getting this specific functionality. :grin: But if you really think it would be helpful, I can try to be useful here.