Closed regro-cf-autotick-bot closed 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Just poking in here because this release and package build is very relevant to my interests (i.e., will affect downstream packages like librosa), and I'm not sure how closely the tagged reviewers have been following libsndfile development. Specifically, the 1.1.0 release added mp3 support, but this is not enabled in the current feedstock (see log):
Encoding and decoding mp3 requires new dependencies for lame
and mpg123
, both of which are packaged in conda-forge, so it should be possible to include them without too much additional effort.
@bmcfee thanks for chiming in. That sounds wonderful. Do you want to add the two dependencies to the build and enable MP3?
You could do that in a seperate PR -- then I will hold off merging this one. You can also add yourself as a maintainer to help out with future releases, that would be wonderful.
Do you want to add the two dependencies to the build and enable MP3?
You could do that in a seperate PR -- then I will hold off merging this one.
I can take a crack at it, sure. Would it make sense to fork off of this PR?
You can also add yourself as a maintainer to help out with future releases, that would be wonderful.
I'd rather not get too involved - I'm not actually a libsndfile dev, just a nosy busybody with some vested interest in getting this specific functionality. :grin: But if you really think it would be helpful, I can try to be useful here.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2048181198, please use this URL for debugging.