Added make build requirement

conda-forge / libsolv-feedstock

A conda-smithy repository for libsolv.

BSD 3-Clause "New" or "Revised" License

4 stars 17 forks source link

Closed step21 closed 4 years ago

step21 commented 4 years ago

On aarch64 make is not preinstalled, though things that use make to build need it as requirement.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

wolfv commented 4 years ago

Can you use - make # [not win]?

Otherwise, great!

wolfv commented 4 years ago

also we should increment the build number regardless, because as far as i know the old builds will be overridden.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [26]

step21 commented 4 years ago

Ok changed it

wolfv commented 4 years ago

I am ignoring the linter now, because we can easily fix that in the future.

step21 commented 4 years ago

Thanks. Sorry about the extra space.