conda-forge / libsoup-feedstock

A conda-smithy repository for libsoup.
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Windows + libsoup 3.x #46

Open hmaarrfk opened 9 months ago

hmaarrfk commented 9 months ago

Comment:

I understand that libsoup 3.x requires nghttp2. I have helped compile that.

However, today, the blocker is on gir gobject-introspection not working correctly.

Would it be ok to release libsoup3 without gir for windows?

xref: https://github.com/conda-forge/libsoup-feedstock/pull/45

hmaarrfk commented 9 months ago

@conda-forge-admin please rerender

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I started rerendering the recipe in conda-forge/libsoup-feedstock#47.

hmaarrfk commented 9 months ago

In a previous build the following used to be used to copy a known working of the files over:

:: The gir files produced by the build are currently broken, don't know why...
copy %RECIPE_DIR%\gir\*typelib %LIBRARY_LIB%\girepository-1.0\
if errorlevel 1 exit 1
copy %RECIPE_DIR%\gir\*gir %LIBRARY_PREFIX%\share\gir-1.0\
if errorlevel 1 exit 1
hmaarrfk commented 9 months ago

Perhaps this can be a clue https://github.com/conda-forge/librsvg-feedstock/blob/main/recipe/bld.bat

tschoonj commented 9 months ago

I don't think we should release a Windows build of libsoup 3 without gobject-introspection, as it feels like a step backwards from what libsoup 2 offered.

However, I won't be the one putting in the fix due to a lack of time and resources, so if you insist we proceed then I am ok with that.

hmaarrfk commented 9 months ago

feels like a step backwards from what libsoup 2 offered.

I get it. but honestly, given the time resources we have, it isn't all that meaningful to keep building two branches, especially when one is of quite an old version.

PS. a made a few PRs to your feedstocks to help keep libraries in sync. Let me know if you need my help maintaining by adding me as a maintainer there.