search

conda-forge / libspatialite-feedstock

A conda-smithy repository for libspatialite.
BSD 3-Clause "New" or "Revised" License
4 stars 11 forks source link

Rebuild for geos3103 #84

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

This PR has been triggered in an effort to update geos3103.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2441096594, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

gillins commented 2 years ago

check_virtualtable6 test is failing. Does anyone know if this is serious?

BTW seems we don't run the tests on Windows.

xylar commented 2 years ago

@gillins, I saw that, too. No idea, I'm afraid and I didn't see any issue about it on https://www.gaia-gis.it/fossil/libspatialite/rptview?rn=1

Windows checks would be good. I think there's generally a lack of Windows expertise among conda-forge maintainers so that may explain why they have been skipped?

gillins commented 2 years ago

Windows checks would be good. I think there's generally a lack of Windows expertise among conda-forge maintainers so that may explain why they have been skipped?

I guess so. I actually think I may have made the call to disable them here, but no recollection why but it does ring a bell for me. Might be good to see if we can get them going. Do you think it is safe to disable this test, or should we wait until fixed upstream?

xylar commented 2 years ago

Regarding disabling the test, it might be worth checking upstream to see if this indicates a serious problem. But I don't have time to do that right now. If you don't either, we could disable the test and wait to see if folks complain about issues...

gillins commented 2 years ago

Seems the currently skipped tests are fixed in trunk: https://www.gaia-gis.it/fossil/libspatialite/tktview?name=bd44c48c06

gillins commented 2 years ago

Seems the currently skipped tests are fixed in trunk

I'm not sure about the check_virtualtable6 one, but maybe we try again after the next release in the hope this is fixed too.

BTW there is no check or test target in the Windows makefile.vc so not sure what we can do here....