Added Windows support - Githubissues

conda-forge / libtheora-feedstock

A conda-smithy repository for libtheora.

BSD 3-Clause "New" or "Revised" License

0 stars 10 forks source link

Added Windows support #1

Closed dschreij closed 7 years ago

dschreij commented 7 years ago

Windows libraries are built using CMake. There are a few sidenotes to the current implementation:

I created a static and dynamic build separately. Normally when you create a dynamic build, the compiler also creates a static .lib referencing the .dll file, but this doesn't happen for theora. My knowledge of C and compilers, or CMake, doesn't go far enough to know why, so I solved this by explicitly building the library again in static form. I don't know if this is redundant.
I can't see how I could compile the theoraenc or theoradec binaries on windows, or if this is possible at all. So for windows, only the library is created, but no binaries to use it.

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dschreij commented 7 years ago

@bgruening @jakirkham Windows support has been added, but AppVeyor and CircleCI don't start. Especially AppVeyor will be interesting of course ;)

jakirkham commented 7 years ago

Ah, so you need to re-render after changing skip in any way. Please you conda-smithy version 1.7.0 and please make sure your .condarc contains the section below before re-rendering. Can be removed after.

channels:
  - conda-forge
  - defaults

Future versions of conda-smithy will not require this .condarc change.

jakirkham commented 7 years ago

Also we had some issues with CircleCI. Have already fixed this repo (just now verified). Manually triggered the build just now.

xref: https://github.com/conda-forge/status/issues/30

dschreij commented 7 years ago

I says conda smithy rerender doesn't have anything to do:

conda smithy rerender
No circle token.  Create a token at https://circleci.com/account/api and
put it in ~/.conda-smithy/circle.token
No appveyor token. Create a token at https://ci.appveyor.com/api-token and
Put one in ~/.conda-smithy/appveyor.token
No anaconda token. Create a token via
  anaconda auth --create --name conda-smithy --scopes "repos conda api"
and put it in ~/.conda-smithy/anaconda.token
Using Anaconda API: https://api.anaconda.org
Fetching package metadata ...........
Fetching package metadata ...........
Fetching package metadata ...........
Fetching package metadata ...........
Fetching package metadata ...........

Re-rendered with conda-smithy 1.7.0.

No changes made. This feedstock is up-to-date.

dschreij commented 7 years ago

Alright, now it worked...

jakirkham commented 7 years ago

What changed?

bgruening commented 7 years ago

Cool beans @dschreij! Thanks for following up on this and sorry for my late rely, was on tour.

dschreij commented 7 years ago

I don't know. I rebased with master first and that undid all my changes to the meta.yaml (setting skip back to True for Windows). After I reapplied my changes to meta.yaml and reran conda-smithy it worked.