search

conda-forge / libtheora-feedstock

A conda-smithy repository for libtheora.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

Windows support #4

Closed jakirkham closed 4 years ago

jakirkham commented 6 years ago

Appears there are no Windows builds of libtheora. Though there does appear to be a CMakeLists.txt included for this purpose. Would it be possible to make Windows builds? Any known blockers?

jakirkham commented 6 years ago

Attempting to fix in PR ( https://github.com/conda-forge/libtheora-feedstock/pull/7 ).

dschreij commented 6 years ago

No idea. when I composed all these packages, I made sure they worked on Windows, as this was a requirement for us. I don't know why the Windows builds are missing now.

jakirkham commented 6 years ago

Good to know there should be no technical blockers.

Think they are missing because of this skip line. Am trying to take it out and re-render.

jakirkham commented 6 years ago

Looks like inline assembly is required, but Window 64-bit's Visual Studio Compilers do not support this.

xref: https://github.com/conda-forge/libtheora-feedstock/pull/7#issuecomment-388646497

jschueller commented 4 years ago

@jakirkham looks like this one can be closed

jakirkham commented 4 years ago

Thanks @jschueller! Closed with PR ( https://github.com/conda-forge/libtheora-feedstock/pull/10 ).