Re-add patch for CVE-2017-11613, put Windows DLL name back to tiff.dl…

conda-forge / libtiff-feedstock

A conda-smithy repository for libtiff.

BSD 3-Clause "New" or "Revised" License

1 stars 25 forks source link

Re-add patch for CVE-2017-11613, put Windows DLL name back to tiff.dl… #36

Closed mingwandroid closed 5 years ago

mingwandroid commented 5 years ago

…l, providing libtiff.dll too for compat.

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Ensured the license file is being packaged.

Fixes https://github.com/conda-forge/libtiff-feedstock/issues/35

We also copy tiff.dll to libtiff.dll to maintain compat. with Anaconda Defaults (which will also adopt this PR, more or less, just without any requirements/run).

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mingwandroid commented 5 years ago

Ping @hobu

Off to bed now, let's see how this goes in the morning.

mingwandroid commented 5 years ago

If you do not have XQuartz in the CI then it will not link to XQuartz, these lines are irrelevant to conda-forge, but necessary for defaults since we disagree about not using XQuartz when it is available, we positively encourage it as it is the defacto X implementation on macOS.

Please just ignore these lines and don't worry about it.

mingwandroid commented 5 years ago

And I firmly want to send out the message that "Anaconda Defaults will link things to XQuartz when there's no alternative, and strives to make every package as feature complete as possible". So this is in-line with that.

mingwandroid commented 5 years ago

Can someone merge this if it's OK now?