Rebuild for fixed zstd - Githubissues

conda-forge / libtiff-feedstock

A conda-smithy repository for libtiff.

BSD 3-Clause "New" or "Revised" License

1 stars 25 forks source link

Rebuild for fixed zstd #45

Closed jpgill86 closed 4 years ago

jpgill86 commented 4 years ago

Closes #44.

Note the issue described in #44 may also be affecting pillow (conda-forge/pillow-feedstock#66) and packages that use it, like matplotlib.

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] ~~Reset the build number to 0 (if the version changed)~~ (N/A)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jpgill86 commented 4 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance.

jpgill86 commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance.

@conda-forge/core, I got this unexpected response from the linter when rerendering. Help?

jpgill86 commented 4 years ago

Hmm, it appears that simply rebuilding did not update the zstd requirements as I expected.

As I mentioned in #44, the latest published tar for Windows includes the following in its index.json: zstd >=1.4.3,<1.4.4.0a0. Since this pinning to version 1.4.3 isn't given explicitly in meta.yaml, I'm not sure how it got into the tar. I guessed that a script was fetching the latest zstd version number at build time and plugging it in. However, although I don't have direct access to the recipe built by Azure, I can see in the log that zstd 1.4.3, rather than the latest 1.4.4, was used while building and testing. I presume that means that the pinning wasn't updated, but I can't be sure.

Does someone with more experience with libtiff know what might be going on viz-a-viz the zstd versioning?

ocefpaf commented 4 years ago

This is following the global pinning, see https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/59a775b21dc27d16e7232d9546a7ea930e4e36d4/recipe/conda_build_config.yaml#L607-L608

In order to change that we must propose a migration to the latest zstd in https://github.com/conda-forge/conda-forge-pinning-feedstock/ first.

jpgill86 commented 4 years ago

Thanks @ocefpaf, I wasn't aware of that!