Add WebP codec support to libtiff

conda-forge / libtiff-feedstock

A conda-smithy repository for libtiff.

BSD 3-Clause "New" or "Revised" License

1 stars 25 forks source link

Add WebP codec support to libtiff #48

Closed hobu closed 4 years ago

hobu commented 4 years ago

Adding WebP support to allow applications like GDAL to read and compress WebP TIFF content. It was prompted by https://rasterio.groups.io/g/main/message/383

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hobu commented 4 years ago

BTW, according to the Changelog, I think the CVE patches applied in this recipe are fixed in libtiff 4.1.0.

https://gitlab.com/libtiff/libtiff/blob/master/ChangeLog#L1175

hobu commented 4 years ago

We are currently failing due to a circular dependency. libwebp is depending on libtiff on unix, and this will have to be resolved before this PR can be applied.

ocefpaf commented 4 years ago

We are currently failing due to a circular dependency. libwebp is depending on libtiff on unix , and this will have to be resolved before this PR can be applied.

From @hobu's gitter message:

I think this recipe needs to be broken into two parts – the libwebp code
part that has no dependencies and a part with all of the utilities like
img2webp that can depend on the image libraries.

I'm +1 to that but I don't have the time to try it until mid-January. Do you want to try to implement that?

hobu commented 4 years ago

What is the strategy to split apart the libwebp recipe? Is there an example to follow?

ocefpaf commented 4 years ago

What is the strategy to split apart the libwebp recipe? Is there an example to follow?

I usually recommend matplotlib and gal recipes for that. I'll try that later today and report back on the libwebp recipe.

ocefpaf commented 4 years ago

Needs https://github.com/conda-forge/libwebp-feedstock/pull/24

ocefpaf commented 4 years ago

@conda-forge-admin, please restart ci