Closed hmaarrfk closed 4 years ago
conda-forge-linter
commented
4 years ago Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
hmaarrfk
commented
4 years ago Not too sure how this affects abi compatibility, but this used to be the default in 4.0
This means that 4.1 did break ABI compatibility on windows, but that change went on silently.
djhoese
commented
4 years ago I can't be sure yet, but I think this new build is breaking libtiff (the python package on PyPI) being able to use libtiff (the C library on conda-forge) on Appveyor. I'll try forcing the old build and see if that helps.
hmaarrfk
commented
4 years ago This may be true. :/ We might have to revert.
djhoese
commented
4 years ago Forcing build 1 (this PR is build 2) gets me further in my testing on appveyor. I'm also in dependency hell with my CI environment trying to install numpy 1.18 from PyPI and it breaking things which is what the above referenced commit got to. Using this PR's build seems to cause a segmentation fault of sorts. The appveyor log just goes from test output to stating the exit status of the appveyor script(s).
Edit: Going offline for probably the rest of the night. I'll try to check email tonight, but otherwise may have to wait for later in the weekend.
hmaarrfk
commented
4 years ago can you wait on numpy 1.18?
Reverting htis in an other PR.
djhoese
commented
4 years ago Sorry for the late reply. I came down with a cold and it hit me hard Friday night.
And yes, I can hold off on numpy 1.18, it wasn't something I actually want but has become the new default "stable" version used by astropy's ci-helpers tool. Things seem to be passing with build 1 on appveyor.
hmaarrfk
commented
4 years ago FYI, build 3 has been released, reverting build 2, so the solver should find that by default now.
djhoese
commented
4 years ago Yep, build 3 works for me. Thanks. Let me know when the next build of this PR is available and i can try it out.
hmaarrfk
commented
4 years ago If you are super inclined you can adding my channel
mark.harfouche https://anaconda.org/mark.harfouche/libtiff/files
It has build 4, which is the same as the live PR i have https://github.com/conda-forge/libtiff-feedstock/pull/51
That said, that PR does quite a bit more testing, so it should be safer ;)
https://github.com/conda-forge/lcms2-feedstock/pull/3#discussion_r362735346 @kmilos
Checklist
0(if the version changed)conda-smithy(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)