Fixup tests for OSX

[hmaarrfk]

Checklist

• [ ] Used a fork of the feedstock to propose changes
• [ ] Bumped the build number (if the version is unchanged)
• [ ] Reset the build number to 0 (if the version changed)
• [ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• [ ] Ensured the license file is being packaged.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

• Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[hmaarrfk]

@conda-forge-admin please rerender

[hmaarrfk]

@ocefpaf can we merge this one too? it just fixes the downstream tests for OSX that were failing before.

Thanks @isuruf for finding the source of the problem.

[isuruf]

Downstream tests should use https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#downstream-tests to avoid cycles.

[hmaarrfk]

will that simply run the downstream test section? I should remove the custom commands and file I added right?

[isuruf]

yes to both

[hmaarrfk]

Does opencv need to be rerendered?https://github.com/conda-forge/opencv-feedstock/issues/220

[isuruf]

Yes. Looks like it. There's also an issue with conda-build at https://github.com/conda/conda-build/issues/3908

[hmaarrfk]

yeah, this isn't really that good, it defaulted to a really old version of opencv 3.4 (3.4.2) which I don't think you or I maintain.

[hmaarrfk]

Lets try again when: https://github.com/conda-forge/opencv-feedstock/pull/221

merges

[hmaarrfk]

opencv was merged, but no job is running on master?

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[hmaarrfk]

@isuruf I really can't understand the conflict, but maybe i'm missing something.

What is the way forward? Do I comment out the opencv test and rebuild opencv when this is pulled in?

[ocefpaf]

@hmaarrfk sorry, I let slip through the cracks. Do you still want to rebase it? If not I can try to fix this PR so we can work on the latest version.

[hmaarrfk]

honestly, i'm really not sure what the current status of the feedstock is.

Would have to redo this work. Maybe lets leave it open until one of us has a chance to do it.?

[ocefpaf]

Maybe lets leave it open until one of us has a chance to do it.?

Tried and failed miserably :smile:

I'll try to find more time and tackle this again later this week. Thanks!

[hmaarrfk]

I just manually copied over the idea of the changes.