conda-forge / libtiff-feedstock

A conda-smithy repository for libtiff.
BSD 3-Clause "New" or "Revised" License
1 stars 25 forks source link

Missing run-dependencies (resp. missing run-exports of the respective host deps) #81

Closed h-vetinari closed 2 years ago

h-vetinari commented 2 years ago

Seen in https://github.com/conda-forge/staged-recipes/pull/19665 (because that recipe ended up copying the DLL to site-packages, and so it showed up in the log):

WARNING (pygame,Lib/site-packages/pygame/libtiff.dll): Needed DSO Library/bin/libdeflate.dll found in ['libdeflate']
WARNING (pygame,Lib/site-packages/pygame/libtiff.dll): .. but ['libdeflate'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
WARNING (pygame,Lib/site-packages/pygame/libtiff.dll): Needed DSO Library/bin/Lerc.dll found in ['lerc']
WARNING (pygame,Lib/site-packages/pygame/libtiff.dll): .. but ['lerc'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
WARNING (pygame,Lib/site-packages/pygame/libtiff.dll): Needed DSO Library/bin/zstd.dll found in ['zstd']
WARNING (pygame,Lib/site-packages/pygame/libtiff.dll): .. but ['zstd'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
hmaarrfk commented 2 years ago

This isn't a libtiff issue.

The libtiff package correctly declares them:

2022-06-13T11:54:17.3413761Z    INFO (libtiff,Library/bin/tiff.dll): Needed DSO Library/bin/libdeflate.dll found in conda-forge::libdeflate-1.12-h8ffe710_0
2022-06-13T11:54:17.3425919Z    INFO (libtiff,Library/bin/tiff.dll): Needed DSO Library/bin/Lerc.dll found in conda-forge::lerc-3.0-h0e60522_0
2022-06-13T11:54:17.3437151Z    INFO (libtiff,Library/bin/tiff.dll): Needed DSO Library/bin/zstd.dll found in conda-forge::zstd-1.5.2-h6255e5f_1

That package should not be copying a dll to the site package directory.

h-vetinari commented 2 years ago

Thanks for the quick response

That package should not be copying a dll to the site package directory.

Yeah, I got that, but had somehow managed to confuse myself into thinking that libtiff itself wasn't bringing all its friends along. 😅