Fix linker flags on Win

conda-forge / libusb-feedstock

A conda-smithy repository for libusb.

BSD 3-Clause "New" or "Revised" License

0 stars 6 forks source link

Fix linker flags on Win #11

Closed Tobias-Fischer closed 3 years ago

Tobias-Fischer commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 3 years ago

libftdi build still fails (https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=307202&view=logs&j=a70f640f-cc53-5cd3-6cdc-236a1aa90802&t=f5d15007-a01c-5ad8-c9ce-4d519d3b275f) - I think this should fix it.

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

ryanvolz commented 3 years ago

The error in the build seems to be happening before it gets to the linker flags, so I don't think this will help. It's not even finding libusb from pkg-config at this point, which is a mystery to me.

Tobias-Fischer commented 3 years ago

Ah, okay. I thought

-- Could NOT find LIBUSB (missing: LIBUSB_LIBRARIES)

Indicates that it just can't find the libraries.

ryanvolz commented 3 years ago

Looks good as-is after all, see https://github.com/conda-forge/libftdi-feedstock/pull/1.