Closed ryanvolz closed 4 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:
{{<one space><variable name><one space>}}
form. See lines [9].Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@ryanvolz Thanks for the contribution! Looks okay to me :)
Would you like to add yourself as a maintainer too?
I already am 😉, I just thought this one could use some looking over.
Oh. Haha sorry :) Too much stuff going on around me :D Yeah I suggest we merge this and if users report any problems, we reconvene? ;)
Sounds good!
Work around missing libudev.so.0 on modern Linux systems. This has been a pain for a while now, and something I've had to instruct multiple users to work around.
This adds a post-link script that checks for missing libudev.so.0 and, if missing, adds a symbolic link to the environment that points to the system's libudev.so.1. There is also a pre-unlink script that removes that symbolic link if required. And if any of that fails, it should just carry on anyway.
This is pretty hacky, but it works for me locally with my Ubuntu system. Hopefully I made it general enough to work with other distributions as well? If/when the libudev CDT gets updated (for, say, CentOS 7) this probably won't be necessary anymore, but I think it could be pretty helpful until then.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Fixes #1