enable x11 - Githubissues

conda-forge / libva-feedstock

A conda-smithy repository for libva.

BSD 3-Clause "New" or "Revised" License

0 stars 5 forks source link

enable x11 #25

Closed gabm closed 2 years ago

gabm commented 2 years ago

Enable the x11 libva backend by providing the dependencies

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

gabm commented 2 years ago

@hmaarrfk please have a look!

hmaarrfk commented 2 years ago

Out of curiosity, what does x11 give the end user?

hmaarrfk commented 2 years ago

Could you add a test for the creation of the so file.

It seems that a new so file is added:

2022-01-19T15:28:59.7774726Z    INFO (libva,lib/libva-x11.so.2.1300.0): lib/libva.so.2 found in this package

hmaarrfk commented 2 years ago

Are you also willing to help maintain this feedstock?

gabm commented 2 years ago

Out of curiosity, what does x11 give the end user?

I want to build a library that assumes that libva had been built with x11 enabled. Adding the dependencies enables that support in libva and my lib builds

Could you add a test for the creation of the so file.

thanks for spotting that, done!

Are you also willing to help maintain this feedstock?

of course, added myself as maintainer...