conda-forge / libva-feedstock

A conda-smithy repository for libva.
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Revert "Relax overlinking errors because of compatibility issues" #38

Closed ehfd closed 2 months ago

ehfd commented 2 months ago

Reverts conda-forge/libva-feedstock#37

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-webservice.

It appears you are making a pull request from a branch in your feedstock and not a fork. This procedure will generate a separate build for each push to the branch and is thus not allowed. See our documentation for more details.

Please close this pull request and remake it from a fork of this feedstock.

Have a great day!

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 2 months ago

in the future, we need a "build number bump" too...

hmaarrfk commented 2 months ago

please allow the bots to finish, before pressing merge, you are moving a little too fast.

While it is OK to sometimes break the rules, there is an "automerge" that would have allowed me 1 second to help by bumping the build number to 3.

ehfd commented 2 months ago

Ah, I kinda panicked a bit. I'll remember that.

hmaarrfk commented 2 months ago

honestly, its all cool, the problem seems that libxcb isn't listed in our global pinnings, so every feedstock is choosing a different minor version.

I need to patch up build 2 with the 1.15 restriction, then we can move to fixing the underlying problem.

ehfd commented 2 months ago

I think build 1 had a >=1.16,<1.17 restriction, that's what was the issue I think.

Also, I wonder why https://anaconda.org/conda-forge/libxcb and https://anaconda.org/search?q=libxcb show different versions...

hmaarrfk commented 2 months ago

its probably because other packages are pinned to 1.15 causing 1.15 to be the most downloaded version.