search

conda-forge / libvorbis-feedstock

A conda-smithy repository for libvorbis.
BSD 3-Clause "New" or "Revised" License
2 stars 8 forks source link

Migrate to Jinja2 compiler syntax #3

Closed regro-cf-autotick-bot closed 6 years ago

regro-cf-autotick-bot commented 6 years ago

List of changes done to the recipe: Renamed build with host Moving python # [win] which was used for vc matrix Moving cmake from host to build Removing toolchain in favour of compiler() Removing vc features Removing features section as it is empty Adding C compiler

If you have recived a Migrate to Jinja2 compiler syntax PR from me recently please close that one and use this one. It is very likely that this feedstock is in need of migration. Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed. This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.

Finally, feel free to drop us a line if there are any issues!

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 6 years ago

It doesn't like the LIBRARY_BIN part of this line. Dropping that should fix it.

https://github.com/conda-forge/libvorbis-feedstock/blob/e048877e439ee4a4ae0a0620ba028d94ed0c9059/recipe/bld.bat#L10

dschreij commented 6 years ago

Alright, removed that entry