search

conda-forge / libxcb-feedstock

A conda-smithy repository for libxcb.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

ARM OSX Migrator #14

Closed regro-cf-autotick-bot closed 3 years ago

regro-cf-autotick-bot commented 3 years ago

This feedstock is being rebuilt as part of the ARM OSX migration.

Feel free to merge the PR if CI is all green, but please don't close it without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/470792071, please use this URL for debugging

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pkgw commented 3 years ago

Surprising issue here!

    from fractions import gcd
ImportError: cannot import name 'gcd' from 'fractions'

It looks like maybe this is deprecated and math.gcd should be used.

erykoff commented 3 years ago

https://docs.python.org/3.8/library/fractions.html#fractions.gcd seems to have been deprecated a while ago and removed in 3.9

erykoff commented 3 years ago

I guess xcb-proto needs to be patched.

erykoff commented 3 years ago

https://github.com/conda-forge/xcb-proto-feedstock/pull/15

pkgw commented 3 years ago

For the record, the docs say that math.gcd was introduced in 3.5, so we can rely on it.

pkgw commented 3 years ago

@conda-forge-admin please restart ci

erykoff commented 3 years ago

I think the update hasn’t made it through to the cdn yet. We should try again in a few hours.

pkgw commented 3 years ago

Yeah, I was overeager.

pkgw commented 3 years ago

@conda-forge-admin please restart ci

erykoff commented 3 years ago

Strange that math.gcd is failing on arm64. I will investigate.

erykoff commented 3 years ago

Fixed on #15