search

conda-forge / libxcb-feedstock

A conda-smithy repository for libxcb.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

Update to 1.15 #18

Closed conda-forge-admin closed 1 year ago

conda-forge-admin commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I've rerendered the recipe as instructed in #17.

Here's a checklist to do before merging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 1 year ago

see announcement: https://xcb.freedesktop.org/

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

hmaarrfk commented 1 year ago

needs: https://github.com/conda-forge/xcb-proto-feedstock/pull/21

pkgw commented 1 year ago

I think just a bit more time needs to elapse before the updated xcb-proto packages are propagated into the channels.

hmaarrfk commented 1 year ago

yeah, i guess i'm just impatient.

hmaarrfk commented 1 year ago

The windows failure seems real.

pkgw commented 1 year ago

Error message is:

Making all in src
Makefile:1304: *** multiple target patterns.  Stop.

That's one that I'm pretty sure I've never seen before!

hmaarrfk commented 1 year ago

Lol

pkgw commented 1 year ago

Looks like the variable XCBPROTO_XCBINCLUDEDIR contains a drive letter with a colon (/C:/Users/conda/...) and that's interacting poorly with the Makefile grammar. I'll need to track down where that's coming from, but I think it would be better for the variable to not have the colon anyway (/C/User/conda/...) so this shouldn't be a big deal to straighten out.

Update: it comes from $PKG_CONFIG --variable=xcbincludedir xcb-proto so we'll have to update the xcb-proto package, I think.

pkgw commented 1 year ago

OK, based on my local testing, https://github.com/conda-forge/xcb-proto-feedstock/pull/22 should fix the Windows build here.