aarch64, ppc64le and osx

conda-forge / lief-feedstock

A conda-smithy repository for lief.

BSD 3-Clause "New" or "Revised" License

1 stars 15 forks source link

aarch64, ppc64le and osx #1

Closed isuruf closed 5 years ago

isuruf commented 5 years ago

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

isuruf commented 5 years ago

@conda-forge-admin, rerender

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'liblief' output doesn't have any tests.

isuruf commented 5 years ago

@mingwandroid, do you know why this fails on ppc64le?

mingwandroid commented 5 years ago

Kind of. I resolved not to fix it though as we have pyldd there instead. So long as I keep that working in conda-build I'll find things that will take priority over this.

mingwandroid commented 5 years ago

The LIEF devs are nice and are responsive to PRs.

isuruf commented 5 years ago

@conda-forge-admin, rerender