Fix build issue with python 3.8 on Windows

conda-forge / lief-feedstock

A conda-smithy repository for lief.

BSD 3-Clause "New" or "Revised" License

1 stars 15 forks source link

Fix build issue with python 3.8 on Windows #12

Closed benjamb closed 4 years ago

benjamb commented 4 years ago

Imports the patch as merged in upstream: see https://github.com/lief-project/LIEF/pull/453.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Fixes #11.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'liblief' output doesn't have any tests.

benjamb commented 4 years ago

@conda-forge-admin, please rerender

benjamb commented 4 years ago

The build errors with ImportError: Module use of python36.dll conflicts with this version of Python., which is different to the Fatal Python error: PyThreadState_Get: no current thread message.

isuruf commented 4 years ago

Thanks