search

conda-forge / lief-feedstock

A conda-smithy repository for lief.
BSD 3-Clause "New" or "Revised" License
1 stars 15 forks source link

Rebuild for python38 #4

Closed regro-cf-autotick-bot closed 4 years ago

regro-cf-autotick-bot commented 5 years ago

This PR has been triggered in an effort to update python38.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed. Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/11822, please use this URL for debugging

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

isuruf commented 4 years ago

@conda-forge-admin, rerender

mbargull commented 4 years ago

Build on Azure timed out too.

mbargull commented 4 years ago

What should we do about Windows builds here? If we don't do a build for Python 3.8 on Windows, then the rebuild of conda-build will fail since defaults does not have 3.8 builds of it. Not my area of expertise, hence I don't know whether conda-build uses py-lief on Windows or not, i.e., if would be fine to just change - py-lief # [not (win and py2k)] to - py-lief # [not win].

edit: rebuild PR for conda-build went already up: https://github.com/conda-forge/conda-build-feedstock/pull/120

mingwandroid commented 4 years ago

0.10.0 was just released. I'll try to enable Windows for Python 3 when I try to update LIEF.

mingwandroid commented 4 years ago

Windows python 3.8 is proving problematic (some threading or startup error) and I don't have time to look into it at present. If anyone else has, help would be appreciated.