0.10.1 fixes - Githubissues

conda-forge / lief-feedstock

A conda-smithy repository for lief.

BSD 3-Clause "New" or "Revised" License

1 stars 15 forks source link

0.10.1 fixes #7

Closed mingwandroid closed 4 years ago

mingwandroid commented 4 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'liblief' output doesn't have any tests.

isuruf commented 4 years ago

@conda-forge-admin, rerender

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance. You can also try re-rendering locally.

mingwandroid commented 4 years ago

@isuruf, where is the vs2017 package's feedstock? I added setting CC and CXX to the defaults package one now.

isuruf commented 4 years ago

@mingwandroid, we are using a copy of defaults's build before the latest due to https://github.com/conda-forge/llvmdev-feedstock/pull/73#issuecomment-533756169 I haven't had time to look into it yet.

mingwandroid commented 4 years ago

I'm a bit confused by the Windows failure. It's specific to Python 3.8 and it doesn't matter whether I statically or dynamically link lief.pyd to the lief library (libLIEF.dll when dynamic, my preference).

I suspect something is broken with CMake's FindPython and I am adding some tests to AnacondaRecipe's python 3.8 recipe to try to shake this out. Any insights would be appreciated, pinging @msarahan and @isuruf.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.