Closed mbargull closed 4 years ago
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
meta.yaml
, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint .
from the recipe directory. Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:
Windows + py38 is a known upstream issue. https://github.com/lief-project/LIEF/issues/404
@isuruf, thanks that's good to know.
However, somehow @mingwandroid got one built for the main
channel (even with shared linking? https://github.com/AnacondaRecipes/lief-feedstock/commit/18a5166e6eb9dda7260af4ddf5a7f4789a82d3a9).
That package appears to be broken, https://github.com/conda/conda-build/issues/3963
Ah, okay. Thanks!
That package appears to be broken, conda/conda-build#3963
We need this in our Python: https://github.com/AnacondaRecipes/python-feedstock/blob/master/recipe/patches/0026-Revert-part-of-https-bugs.python.org-issue33895-http.patch
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)closes gh-6 gh-7
This merges https://github.com/AnacondaRecipe/lief-feedstock/ which has version 0.10.1 and py38 Windows support.
Currently, this is only has merge and rerender commits, nothing else. Probably needs some further work (e.g., re-introducing https://github.com/conda-forge/lief-feedstock/pull/4/files#r352034669 etc.). Opening a draft PR just to see how it goes.