search

conda-forge / llvmdev-feedstock

A conda-smithy repository for llvmdev.
BSD 3-Clause "New" or "Revised" License
8 stars 42 forks source link

llvmdev v15.0.3 #178

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
llvmdev 15.0.3 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

Packages found in the meta.yaml but not found by source code inspection:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3272876938, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 2 years ago

Interesting...

CMake says:

-- Found zstd: D:/bld/llvm-package_1666094694391/_h_env/Library/lib/zstd.lib
-- [...]
-- Configuring done

but then

CMake Warning (dev) in CMakeLists.txt:
  Policy CMP0111 is not set: An imported target missing its location property
  fails during generation.  Run "cmake --help-policy CMP0111" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  IMPORTED_IMPLIB not set for imported target "zstd::libzstd_shared"
  configuration "Release".
This warning is for project developers.  Use -Wno-dev to suppress it.

and finally:

>cmake --build . 
ninja: error: 'zstd::libzstd_shared-NOTFOUND', needed by 'bin/llvm-tblgen.exe', missing and no known rule to make it
xhochy commented 2 years ago

zstd package contents look OK. I wonder whether there is a problem with IMPORTED_IMPLIB_RELEASE and IMPORTED_IMPLIB here.

# Import target "zstd::libzstd_shared" for configuration "Release"
set_property(TARGET zstd::libzstd_shared APPEND PROPERTY IMPORTED_CONFIGURATIONS RELEASE)
set_target_properties(zstd::libzstd_shared PROPERTIES
  IMPORTED_IMPLIB_RELEASE "${_IMPORT_PREFIX}/lib/zstd.lib"
  IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/bin/zstd.dll"
  )
h-vetinari commented 2 years ago 
CMake Error in CMakeLists.txt:
  IMPORTED_IMPLIB not set for imported target "zstd::libzstd_shared"
  configuration "Release".

The interesting thing is that nothing about https://github.com/conda-forge/zstd-feedstock changed for >2 months.

xhochy commented 2 years ago

LLVM now ships its only very rudimentary Findzstd.cmake: https://reviews.llvm.org/D134990

xhochy commented 2 years ago

https://reviews.llvm.org/D136065 could also be a fix for this

h-vetinari commented 2 years ago

Nice sleuthing! 👌

It's not clear to me from https://github.com/conda-forge/llvmdev-feedstock/pull/178/commits/a38870741c17f0913f9ed6467d8af3d07d17c5fa how much is rebasing, and how much is (potentially non-obvious) adaptations you made - I ask because I'm thinking about raising an issue for https://reviews.llvm.org/D136065 to be backported

xhochy commented 2 years ago

I did also include https://reviews.llvm.org/D135457 in the latest rebase, I should update the comment.

h-vetinari commented 2 years ago

I ask because I'm thinking about raising an issue for https://reviews.llvm.org/D136065 to be backported

No need anymore: https://github.com/llvm/llvm-project/issues/58205

h-vetinari commented 2 years ago

I should update the comment.

Is it important to you? Otherwise I think we're good to go. 🥳

xhochy commented 2 years ago

I should update the comment.

Is it important to you? Otherwise I think we're good to go. 🥳

With the merged changes upstream, not really.

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

bluescarni commented 2 years ago

The zstd business seems to have broken something on Windows builds:

https://github.com/bluescarni/heyoka/actions/runs/3300936955/jobs/5445923768#step:5:375

h-vetinari commented 2 years ago

Thanks for the info @bluescarni, sorry for the breakage!

Do you think you could open a bug upstream, referencing that 15.0.3 plus the backports from https://github.com/llvm/llvm-project/issues/58205 causes a failure for you (+ circumstances)?

bluescarni commented 2 years ago

@h-vetinari I reported the issue upstream:

https://github.com/llvm/llvm-project/issues/58558