Closed h-vetinari closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@isuruf, any preference for how to fix this? I avoided m2-sed
because @hmaarrfk had asked me not to mix stacks where possible, but while I debugged the powershell invocation locally, it doesn't seem to trigger correctly in CI.
I'd know how to do it with sed, but not what's currently going wrong with powershell.
It's fine to use m2-sed
in build.
@conda-forge-admin, please rerender
@isuruf, this is passing now, any further comments/wishes? I've also ported this fix to the other branches in #215 & #216
Here's the file (after sed-replacement):
%LIBRARY_LIB%\cmake\llvm\LLVMExports.cmake
Isn't this PR doing multiple things? What's the reason for going away from the supposed "standard code practices" in this case?
What's the reason for going away from the supposed "standard code practices" in this case?
I'm trying to avoid doing too many rebuilds, which cause lots of artefact & download churn. All these changes are well-understood and the diff is <100 lines, so bundling them is IMO not an issue. If you prefer me to split, I can do it.
For me, it's different from boost in terms of scope (3 small things vs. complete-recipe-rewrite), so the fact that each PR actually builds artefacts tips the balance towards bundling here.
Fixes #175 Fixes https://github.com/conda-forge/clangdev-feedstock/issues/202
Also backport #210 & #222 Closes #222