conda-forge / llvmdev-feedstock

A conda-smithy repository for llvmdev.
BSD 3-Clause "New" or "Revised" License
8 stars 41 forks source link

Re-enable zstd-support in cross-compilation #203

Closed h-vetinari closed 1 year ago

h-vetinari commented 1 year ago

There were some issues with zstd in #163, let's try re-enabling it.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 1 year ago

I think there's a bootstrapping issue here. We'd need a native llvm-config for the cross-compilation builds, but we're only building that one in the same PR...

isuruf commented 1 year ago

No, that's incorrect. Please revert 0271056

h-vetinari commented 1 year ago

No, that's incorrect. Please revert 0271056

Done, thanks; I'd normally rebase out those garbage commits, but didn't want to touch yours if not necessary. So far, this PR was more exploratory than anything... :)

isuruf commented 1 year ago

Rebasing should be fine as long as the my commits remain intact.