restore 10.9 support - Githubissues

conda-forge / llvmdev-feedstock

A conda-smithy repository for llvmdev.

BSD 3-Clause "New" or "Revised" License

8 stars 41 forks source link

restore 10.9 support #206

Closed isuruf closed 1 year ago

isuruf commented 1 year ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 1 year ago

This is ready for a review

isuruf commented 1 year ago

I was looking at https://github.com/conda-forge/symengine-feedstock/pull/33 which used 10.9 SDK and was failing with two symbols missing clonefile and pthread_set_qos_class_self_np. clonefile usage was behind a __builtin_available(macos x.x) branch, but pthread_set_qos_class_self_np was not.

Thanks for the review